Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: 쿼리 메서드 이름 개선 및 연관 로직 주석 추가 #274

Merged
merged 4 commits into from
Mar 6, 2024
Merged

refactor: 쿼리 메서드 이름 개선 및 연관 로직 주석 추가 #274

merged 4 commits into from
Mar 6, 2024

Conversation

uwoobeat
Copy link
Member

@uwoobeat uwoobeat commented Mar 6, 2024

🌱 관련 이슈

📌 작업 내용 및 특이사항

  • MemberQueryMethod -> MemberQueryOption
  • queryOption -> matchesQueryOption
  • requirementVerified -> isGrantAvailable
  • 도메인 로직 javadoc에 @see isGrantAvailable 추가

📝 참고사항

📚 기타

@uwoobeat uwoobeat requested a review from a team as a code owner March 6, 2024 13:59
@uwoobeat uwoobeat requested a review from Sangwook02 March 6, 2024 13:59
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 6, 2024

Job Summary for Gradle

Check Style and Test to Develop :: build-test
Gradle Root Project Requested Tasks Gradle Version Build Outcome Build Scan®
gdsc build 8.5 ✅ Build Scan PUBLISHED

Sangwook02
Sangwook02 approved these changes Mar 6, 2024
View reviewed changes
Copy link
Member

@Sangwook02 Sangwook02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@uwoobeat uwoobeat merged commit 2319f1f into develop Mar 6, 2024
1 check passed
@uwoobeat uwoobeat deleted the refactor/271-requirement-domain-logic branch March 6, 2024 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sangwook02 Sangwook02 Sangwook02 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

♻️ 쿼리 메서드 이름 개선 및 연관 로직 주석 추가
2 participants
@uwoobeat @Sangwook02