Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 소셜 로그인 구현 #15

Merged
merged 37 commits into from
Jan 28, 2024
Merged

feat: 소셜 로그인 구현 #15

merged 37 commits into from
Jan 28, 2024

Conversation

uwoobeat
Copy link
Member

@uwoobeat uwoobeat commented Jan 28, 2024

🌱 관련 이슈

📌 작업 내용 및 특이사항

  • 깃허브 소셜 로그인 구현
  • RTR 기법 + Redis 사용하여 리프레시 토큰 관리
  • 쿠키를 사용한 엑세스 토큰 / 리프레시 토큰 관리
  • JWT 인증 필터 구현
  • 테스트 시 redis 컨테이너 실행하는 설정 추가

📝 참고사항

📚 기타

@uwoobeat uwoobeat self-assigned this Jan 28, 2024
@uwoobeat uwoobeat requested a review from a team as a code owner January 28, 2024 06:17
Copy link
Member

@Sangwook02 Sangwook02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인했습니다!

public class JwtService {

private final JwtUtil jwtUtil;
private final MemberRepository memberRepository;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

사용되지 않는 것 같은데 지워도 될 것 같습니다

Comment on lines 87 to 94
public boolean isAccessTokenExpired(String accessTokenValue) {
try {
jwtUtil.parseAccessToken(accessTokenValue);
return false;
} catch (ExpiredJwtException e) {
return true;
}
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이 부분 역시 지워도 될 것 같습니다

Copy link
Member

@Sangwook02 Sangwook02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@uwoobeat uwoobeat merged commit b4bd4fb into develop Jan 28, 2024
1 check passed
@uwoobeat uwoobeat deleted the feature/12-social-login branch January 28, 2024 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

✨ 소셜 로그인 도입
2 participants