Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: 소셜 로그인 후 리다이렉트 경로를 지정하도록 변경 #127

Merged
merged 10 commits into from
Feb 25, 2024
Merged

feat: 소셜 로그인 후 리다이렉트 경로를 지정하도록 변경 #127

merged 10 commits into from
Feb 25, 2024

Conversation

uwoobeat
Copy link
Member

@uwoobeat uwoobeat commented Feb 24, 2024 •
edited
Loading

🌱 관련 이슈

📌 작업 내용 및 특이사항

  • 프론트에서 요청 보낼 때 CORS 에러 발생하는 이슈 -> 프론트에서 직접 리다이렉트 하도록 이슈 추가
  • 서버에서는 referer 헤더 기반으로 sendRedirect 하도록 수정 ({baseUrl}/social-login/redirect)
  • @EnableWebSecurity(debug = true) 사용 시 발생하는 이슈로 인해 스프링부트 버전업

📝 참고사항

📚 기타

@uwoobeat uwoobeat self-assigned this Feb 24, 2024
@uwoobeat uwoobeat requested a review from a team as a code owner February 24, 2024 18:49
@github-actions GitHub Actions
Copy link

Job Summary for Gradle

Build and Deploy to Develop :: build-deploy
Gradle Root Project Requested Tasks Gradle Version Build Outcome Build Scan®
gdsc build 8.5 ✅ Build Scan PUBLISHED

Sangwook02
Sangwook02 approved these changes Feb 25, 2024
View reviewed changes
Copy link
Member

@Sangwook02 Sangwook02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@uwoobeat uwoobeat merged commit 9aacd4a into develop Feb 25, 2024
1 check passed
@uwoobeat uwoobeat deleted the feature/123-social-redirect branch February 25, 2024 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sangwook02 Sangwook02 Sangwook02 approved these changes

@binary-ho binary-ho Awaiting requested review from binary-ho binary-ho is a code owner automatically assigned from GDSC-Hongik/backend-dev

Assignees

@uwoobeat uwoobeat

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

✨ 소셜 로그인 후 리다이렉트 경로를 지정하도록 변경
2 participants
@uwoobeat @Sangwook02