Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] : 빌드 에러 수정 #73

Merged
merged 4 commits into from
Jul 28, 2024
Merged

[Fix] : 빌드 에러 수정 #73

merged 4 commits into from
Jul 28, 2024

Conversation

SeieunYoo
Copy link
Contributor

🎉 변경 사항

  • 빌드 에러 수정합니당
  • 빌드 ci 작성합니당

🚩 관련 이슈

🙏 여기는 꼭 봐주세요!

@SeieunYoo SeieunYoo self-assigned this Jul 28, 2024
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

요거 안쓰는 거 같아서 삭제했습니동

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

페이먼츠 라우팅 요기 맞는 지 확인 한번 부탁드립니동

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

p1; 라우팅은 맞습니다! 그런데 이거 보니까 이 컴포넌트는 안쓰이고 있고 JoinRegularMember 컴포넌트로 쓰이고 있는 것 같아요. 요거 삭제하고 저쪽에 핸들러 붙여야 할 것 같네요!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

e0f522b 요기서 JoinRegularMember 에 붙이고 PaymentStatus 는 삭제했어용~

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

요 api 안 써서 삭제해도 될 거 같긴 한디,,

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

안쓰는 거라 삭제해도 될듯해요!

Copy link
Member

@hamo-o hamo-o left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

빠른 수정 감삼당!!
++ svg쪽 에러도 한번 확인 부탁드려용 clie-rule 요거 있는 svg 파일 가서 저장 한번만 해쥬시면 될 것 같아요

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

p1; 라우팅은 맞습니다! 그런데 이거 보니까 이 컴포넌트는 안쓰이고 있고 JoinRegularMember 컴포넌트로 쓰이고 있는 것 같아요. 요거 삭제하고 저쪽에 핸들러 붙여야 할 것 같네요!

Copy link
Contributor

@eugene028 eugene028 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

로컬에서 돌려봤는데 제가 개발한 부분은 문제없이 돌아가는거 같아요 ㅎㅎ
UI 깨지는거 몇개는 제가 수정해서 다른 PR로 올려둘게용
수고하셨습니다!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

안쓰는 거라 삭제해도 될듯해요!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

빌드 체크용으로만 만든 CICD군영

@SeieunYoo SeieunYoo merged commit fa091b5 into dev Jul 28, 2024
1 check passed
@SeieunYoo SeieunYoo deleted the fix/dev-build-error branch July 28, 2024 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants