[이서현] 4주차 과제 - complete #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeonHaeseung
approved these changes
Nov 18, 2023
| private Long id; //id | ||
| private String title; //제목 | ||
| private String content; //내용 | ||
| private LocalDateTime timestamp; //포스팅된 당시의 시각 |
There was a problem hiding this comment.
LocalDateTime 쓴 것 아주 좋아요! 출제 의도를 명확하게 파악했네요😊
JAVA 8이상부터는 LocalDateTime를 쓰면 Hibernate가 자동 지원해준답니다.
Comment on lines
+20
to
+27
| //Many 쪽에 외래키를 둔다. User, Category둘 다 대해 Many쪽임 | ||
| @ManyToOne | ||
| @JoinColumn(name="user_id") | ||
| private User user; | ||
|
|
||
| @ManyToOne | ||
| @JoinColumn(name = "category_id") | ||
| private Category category; |
There was a problem hiding this comment.
일대다 양방향 관계에서 다수 쪽에 외래키를 둔 것 아주 잘했습니다👍
| @Entity | ||
| @Getter | ||
| @Setter | ||
| public class User { |
There was a problem hiding this comment.
User와 Resume의 관계를 일대다 단방향 관계로 설정했네요. 그런데 지금 User 쪽에는 Resume에 대한 참조가 없어서, 이렇게 설정할 경우 나중에 user.getResume()로 참조하는 게 불가능해요. (즉 특정 맴버의 이력서를 조회하는데 불가능하다는 뜻) 그래서 이 경우에는 일대다 양방향으로 설정하거나, 아니면 일대일 단방향으로 설정하고 User 쪽에 외래키를 두는 게 좋습니다.
Comment on lines
+21
to
+23
| private String country; //국가 | ||
| private String city; //도시 | ||
| private String postal_code; //우편번호 |
There was a problem hiding this comment.
이건 팁인데, 이렇게 비슷한 성질의 필드는 하나로 묶어서 새로운 값 타입, 즉 내장 타입으로 만들어주는 것도 좋아요! 내장 타입은 클래스 위에 @Embeddable 어노테이션을 쓰면 사용 가능하답니다.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
제출 상태
help