Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Screen size warning #549

Merged
merged 4 commits into from
Jun 10, 2022
Merged

Screen size warning #549

merged 4 commits into from
Jun 10, 2022

Conversation

Xananax
Copy link
Contributor

@Xananax Xananax commented Jun 10, 2022

Related issues:

Changes

  • fixes the CSS of the warning so it fits on any screen
  • changes the message to remove the implication of "mobile" and focus on screen size only
  • changes the detection logic to not care about aspect ratio, and only trigger under two conditions: either browser window width is under 700px, or height is under 400px, or the orientation is portrait (width < height).

Note: 700px and 400px are arbitrary values. In my personal tests, they seems to be the lowest value after which texts become uncomfortable.

If we want to target mobile users more aggressively with that notice, we can use the media queries (pointer:none), (pointer:coarse), (hover:none), (hover:on-demand) (based on this SO answer

Additionally, this PR adds modifications to the run script so we can download the custom export templates locally easily

@NathanLovato NathanLovato merged commit dd165c7 into main Jun 10, 2022
@NathanLovato NathanLovato deleted the screen-size-warning branch June 10, 2022 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants