Add offline script verifying support using custom build of Godot #469
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactors the code to split the
ScriptVerifier
class to make it into a base class, withtest()
as a virtual function to override, and implements aOfflineScriptVerifier
class. Common functions and data have been moved into theScriptVerifier
.The
OfflineScriptVerifier
class depends on theGDScriptParserWrap
Reference class, which is not part of Godot by normal. It requires a custom build of Godot. I've uploaded export templates that include this class at https://github.com/Razoric480/godot/releases/tag/3.4.4-parser, which are compiled on my fork https://github.com/Razoric480/godot/tree/raz/gdparser-expose. Including them as a binary data through a git push is a bad idea given the size. I'm unsure of a better way - would be some CI magic of sorts I imagine.The
GDScriptParserWrap
class exposes theparse(script_content: String)
,has_error()
,get_error()
,get_error_line()
andget_error_column()
functions by wrapping Godot'sGDScriptParser
class, which isn't normally visible through scripting. I didn't expose warnings because they are only visible during tools (though we blacklist anything of that severity anyway.)global/...
settings removed.Close #300
Fix #310