Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: added further checks to lesson 5 practice 2 with better error messages #262

Merged
merged 1 commit into from
Feb 5, 2022

Conversation

mathmods
Copy link
Contributor

@mathmods mathmods commented Feb 4, 2022

Please check if the PR fulfills these requirements:

  • The commit message follows our guidelines.
  • For bug fixes and features:
    • You tested the changes.
    • You updated the docs or changelog.

Related issue (if applicable): #256

What kind of change does this PR introduce?
Adds a check to practice 2 in lesson 5 that will determine if there are too few or too many points in the polygon, showing a similar, yet more precise error message. Note that the user must have made 3 polygons for this to happen.
Most of these boil down to the draw_square function having been rewritten or draw square being called more than once in a row (with 3 successful polygons). Though I doubt the second reason would happen normally, hence why the error message asks for if the draw square function has been rewritten, and not if it was called twice.

Does this PR introduce a breaking change?
No

@NathanLovato NathanLovato linked an issue Feb 5, 2022 that may be closed by this pull request
@NathanLovato NathanLovato merged commit 8f3a6bd into GDQuest:main Feb 5, 2022
@NathanLovato
Copy link
Contributor

Thanks much!

@mathmods mathmods deleted the lesson-5-clearer-error-message branch February 5, 2022 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drawing Multiple Squares lesson incorrect error
2 participants