Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On firefox scale window work incorect #93

Closed
allkhor opened this issue Jan 3, 2022 · 8 comments
Closed

On firefox scale window work incorect #93

allkhor opened this issue Jan 3, 2022 · 8 comments
Labels
bug Something isn't working as intended
Milestone

Comments

@allkhor
Copy link
Contributor

allkhor commented Jan 3, 2022

Describe the bug
On Firefox scale window work incorrect. Regression from #70

To Reproduce
Steps to reproduce the bug:

  1. Open site https://gdquest.github.io/learn-gdscript/ in Firefox.
  2. Change Firefox window size.
  3. Look how windows it's scaled.

Screenshots

Information about your device (please complete the following information):

  • Xubuntu 16.04.7 LTS
  • Firefox 88.0.1
@allkhor allkhor added the bug Something isn't working as intended label Jan 3, 2022
@YuriSizov
Copy link
Contributor

Do you experience the same behavior in other browsers on that system? Pretty sure @Xananax is using Firefox and he tested that the scaling worked correctly on Linux.

Also, which size is your window there?

@NathanLovato
Copy link
Contributor

NathanLovato commented Jan 3, 2022

I can confirm the issue, this happens especially when using Super RMB to scale the window interactively. It's something I don't do much with browsers so I didn't catch it when reviewing the PR.

@NathanLovato
Copy link
Contributor

@Xananax it seems the flex display with an absolute position at (0,0,0,0) on firefox forces the image to stretch to the browser's edges.

@Xananax Xananax self-assigned this Jan 4, 2022
@Xananax Xananax added this to the 1.0 milestone Jan 4, 2022
@allkhor
Copy link
Contributor Author

allkhor commented Jan 4, 2022

This not happen on Google Chrome browser on the same system.
You can reproduce with Firefox Response Design Mode(Ctrl+Shift+M).
resize_bug

@NathanLovato
Copy link
Contributor

Yes, it's specific to Firefox.

@Th-eo
Copy link

Th-eo commented Jan 4, 2022

Happens to me as well, just to provide some info. If you F11 (Fullscreen) it is alright. Surprisingly enough, this is recent. I played the Demo on Firefox a few days ago and I never noticed this.

@NathanLovato
Copy link
Contributor

This is due to the new resizing code Xananax wrote to make the app scale much better on many devices. The thing is, browsers render the same HTML/CSS differently (which is always a pain). Despite testing, we didn't catch this issue in FF and just need to find a way to make scaling work there.

@YuriSizov
Copy link
Contributor

Should be good now, but it wasn't deployed yet, so no changes on the live website yet!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working as intended
Projects
None yet
Development

No branches or pull requests

5 participants