Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Color "Confusion" in Modulo lesson 15 #430

Closed
MrInventor opened this issue Mar 6, 2022 · 4 comments · Fixed by #437
Closed

Color "Confusion" in Modulo lesson 15 #430

MrInventor opened this issue Mar 6, 2022 · 4 comments · Fixed by #437
Assignees
Labels
content Issues with the lessons, practices, including their code examples
Milestone

Comments

@MrInventor
Copy link

Issue description:
In Lesson15 Modulo in the modulo illustration on the right.
(Which i really like 😊 )

The "number" slider is green and show by green boxes. Makes sense.
The "modulo" is grey but the grey boxes illustrate the remainder.

image

Suggestion:
Move the math part with "Remainder: x" under the sliders.
Change color of "Remainder: x" test to reflect the color of the boxes.
Change the colors for Modulo slider to one that is not used on the boxes.

@MrInventor MrInventor added the content Issues with the lessons, practices, including their code examples label Mar 6, 2022
@NathanLovato NathanLovato added this to the 1.0 milestone Mar 6, 2022
@razcore-rad
Copy link
Contributor

razcore-rad commented Mar 7, 2022

How's this looking? Is it understandable without any explanation?

@NathanLovato
Copy link
Contributor

No, that doesn't read well. It was clearer before. I think it's just a matter of tweaking the original visuals - as mentioned in the first issue, the point causing confusion is that the modulo slider is grey like the grey boxes.

@razcore-rad
Copy link
Contributor

razcore-rad commented Mar 7, 2022

No. This is wrong. In the original exercise version, both sliders are green (on mouse hover) and gray (when mouse isn't hovering over). The original screenshot makes sense just cause it happens that number = 3 and reminder = 3 as well so there are only 3 green boxes. With number = 4, modulo = 6, the remainder is 2 so would mean 2 green boxes. It doesn't correspond to number = 4.

@razcore-rad
Copy link
Contributor

razcore-rad commented Mar 7, 2022

I guess what I'd change in my version is to color-code the sliders the same way whether the mouse hovers or not over them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Issues with the lessons, practices, including their code examples
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants