-
-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Color "Confusion" in Modulo lesson 15 #430
Comments
No, that doesn't read well. It was clearer before. I think it's just a matter of tweaking the original visuals - as mentioned in the first issue, the point causing confusion is that the modulo slider is grey like the grey boxes. |
No. This is wrong. In the original exercise version, both sliders are green (on mouse hover) and gray (when mouse isn't hovering over). The original screenshot makes sense just cause it happens that number = 3 and reminder = 3 as well so there are only 3 green boxes. With number = 4, modulo = 6, the remainder is 2 so would mean 2 green boxes. It doesn't correspond to number = 4. |
I guess what I'd change in my version is to color-code the sliders the same way whether the mouse hovers or not over them. |
Issue description:
In Lesson15 Modulo in the modulo illustration on the right.
(Which i really like 😊 )
The "number" slider is green and show by green boxes. Makes sense.
The "modulo" is grey but the grey boxes illustrate the remainder.
Suggestion:
Move the math part with "Remainder: x" under the sliders.
Change color of "Remainder: x" test to reflect the color of the boxes.
Change the colors for Modulo slider to one that is not used on the boxes.
The text was updated successfully, but these errors were encountered: