Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix setuptools build and add other small fixes #78

Merged
merged 6 commits into from
Jan 3, 2021
Merged

Fix setuptools build and add other small fixes #78

merged 6 commits into from
Jan 3, 2021

Conversation

davcri
Copy link
Contributor

@davcri davcri commented Dec 30, 2020

Please check if the PR fulfills these requirements:

  • The commit message follows our guidelines.
  • For bug fixes and features:
    • You tested the changes. (couldn't test PyPi package upload)
    • You updated the docs or changelog.

Related issue (if applicable): #63, #76

What kind of change does this PR introduce?

make build
python3 -m pip install dist/gdscript_docs_maker-1.5.1-py3-none-any.whl # this build now contains all the necessary python files
python3 -m gdscript_docs_maker # this now runs correctly

Does this PR introduce a breaking change?

Only if ReferenceCollectorCLI.gd needs var directories := ["res://src"].


Disclaimer: I don't have previous experience with Python setuptools or packaging, I just spent some hours reading the doc and tinkering with this repo in order to fix the main workflows of make build and ./generate_reference.

@NathanLovato
Copy link
Contributor

Just tested it, looking good, thanks. Having a src/ directory wasn't necessary but if it's common and people understand it, that's fine. Merging!

@NathanLovato NathanLovato linked an issue Jan 3, 2021 that may be closed by this pull request
1 task
@NathanLovato NathanLovato merged commit d12aa12 into GDQuest:master Jan 3, 2021
@davcri
Copy link
Contributor Author

davcri commented Jan 4, 2021

Thanks for taking time to review this, have a great January! 🎉 💒

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't get it to work without modifying ReferenceCollectorCLI.gd
2 participants