[#94] apply custom404Page #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
Closed
1 task
hanseulhee
approved these changes
Mar 20, 2023
src/pages/404/index.tsx
Outdated
Comment on lines
10
to
11
| <div> | ||
| <h1>NOT FOUND</h1> |
There was a problem hiding this comment.
다시 main으로 돌아가는 버튼이 있으면 좋을 것 같아요
src/pages/404/index.tsx
Outdated
Comment on lines
5
to
6
| import styled from "styled-components"; | ||
| function custom404() { |
There was a problem hiding this comment.
Suggested change
| import styled from "styled-components"; | |
| function custom404() { | |
| import styled from "styled-components"; | |
| function Custom404() { |
이것도 맞추면 좋을 것 같아요
There was a problem hiding this comment.
앗 적용하겠습니다. 근데 제 vscode에서 자동 save 정렬 프리티어 적용하는데 5초이상 걸리더라구요. 그래서 간혹 적용이 안됐나봐요. 주의해서 해보겠습니다.
src/assets/lottieJSON/lottie404.json
Outdated
There was a problem hiding this comment.
lottieJSON 폴더이니 파일명을 lottie404 -> 404 로 수정하는 건 어떤가요?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description