Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactors the forXXX-options #682

Merged
merged 2 commits into from
Dec 19, 2024
Merged

refactors the forXXX-options #682

merged 2 commits into from
Dec 19, 2024

Conversation

unglaublicherdude
Copy link
Member

No description provided.

@unglaublicherdude unglaublicherdude mentioned this pull request Dec 18, 2024
Open
lennartdohmann
lennartdohmann requested changes Dec 18, 2024
View reviewed changes
php/src/vaas/Options/ForSha256Options.php Outdated Show resolved Hide resolved
php/src/vaas/Vaas.php Outdated Show resolved Hide resolved
php/src/vaas/Vaas.php Outdated Show resolved Hide resolved
php/src/vaas/Vaas.php Outdated Show resolved Hide resolved
php/src/vaas/Vaas.php Outdated Show resolved Hide resolved
@ata-no-one
refactors the options
926e18e 
* adds fromVaasOptions function for the forXXXOptions
* removes the default() function as it is not used anywhere
@unglaublicherdude
Copy link
Member Author

thank you for finding that bug

@lennartdohmann lennartdohmann merged commit 7d58aa8 into php/http_api Dec 19, 2024
@lennartdohmann lennartdohmann deleted the php/http_api_options_proposal branch December 19, 2024 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lennartdohmann lennartdohmann lennartdohmann approved these changes

Assignees

@unglaublicherdude unglaublicherdude

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@unglaublicherdude @lennartdohmann @ata-no-one