Fix stuck vaas request if websocket terminated #591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cavus700
force-pushed
the
bugfix/stuck-go-sdk-on-error
branch
3 times, most recently
from
e20cc10 to
f0e2c7d
Compare
pstadermann
reviewed
Sep 4, 2024
golang/vaas/pkg/vaas/vaas.go
Outdated
| @@ -708,3 +734,14 @@ func (v *vaas) readWebSocket(termChan chan<- error) { | |||
| return | |||
| } | |||
| } | |||
|
|
|||
| func (v *vaas) respondAllOpenRequests() { | |||
pstadermann
approved these changes
Sep 4, 2024
cavus700
force-pushed
the
bugfix/stuck-go-sdk-on-error
branch
from
f0e2c7d to
b1f9ab1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when WebSocket request fails the
sendRequest()go routine terminates without consequences and the request itself will never be closed.