Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Php/for stream #366

Merged
merged 6 commits into from
Feb 22, 2024
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
add content-length to the upload
  • Loading branch information
unglaublicherdude committed Feb 21, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
commit 71c6396f2fdf3e3b935b71cf9b3a9a85dd6aad76
1 change: 1 addition & 0 deletions php/src/vaas/Vaas.php
Original file line number Diff line number Diff line change
@@ -462,6 +462,7 @@ private function UploadStream(Stream $stream, string $url, string $uploadToken)
{
$response = $this->_httpClient->put($url, [
'body' => $stream,
unglaublicherdude marked this conversation as resolved.
Show resolved Hide resolved
'content-length' => $stream->getSize(),
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, thanks! @unglaublicherdude

'timeout' => $this->_uploadTimeoutInSeconds,
'headers' => ["Authorization" => $uploadToken]
]);