add resource_owner_password_grant_authenticator #309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pstadermann
approved these changes
Oct 11, 2023
doxthree
added
enhancement
|
As we know have multiple authentication methods, I would prefer if all authentication logic is moved to one module. This would solve the very long module name This is a breaking change, but more clean than the current approach where some of the logic is in I like the approach with the |
secana
requested changes
Oct 23, 2023
|
I assigned the PR to me to implement the changes I had i mind. |
. . Rust: move auth to own module . . . . . Rust: restructure again refactoring of auth module finished add docs and update deps
secana
approved these changes
Nov 3, 2023
secana
approved these changes
Nov 3, 2023
GermanCoding
deleted the
rust/add-resource-owner-password-cred-grant-auth
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.