Skip to content

Commit

Permalink
remove php 7.4 and 8.0 as they are eol. (#362)
Browse files Browse the repository at this point in the history
* remove php 7.4 and 8.0 as they are eol.

also removed an unused dependency

* also remove the versions from the build matrix
  • Loading branch information
unglaublicherdude authored Feb 16, 2024
1 parent 228bc30 commit 0f82646
Show file tree
Hide file tree
Showing 5 changed files with 10 additions and 63 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/ci-php.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ jobs:
runs-on: ubuntu-20.04
strategy:
matrix:
version: ["7.4", "8.0", "8.1", "8.2"]
version: ["8.1", "8.2", "8.3"]
steps:
- name: checkout
uses: actions/checkout@v3
Expand Down
27 changes: 0 additions & 27 deletions php/devcontainers/php-7.4/.devcontainer/devcontainer.json

This file was deleted.

27 changes: 0 additions & 27 deletions php/devcontainers/php-8.0/.devcontainer/devcontainer.json

This file was deleted.

6 changes: 3 additions & 3 deletions php/src/vaas/composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -13,13 +13,13 @@
"license": "MIT",
"homepage": "https://github.com/GDATASoftwareAG/vaas",
"require": {
"php": "^7.4 || ^8",
"php": "^8.1",
"ramsey/uuid": "^4.7 || ^4.2",
"textalk/websocket": "^1.6 || ^1.5",
"netresearch/jsonmapper": "^4.1",
"netresearch/jsonmapper": "^4.4",
"guzzlehttp/guzzle": "^7",
"psr/log": "^1.1 || ^2.0 || ^3.0",
"league/oauth2-client": "^2.4.0"
"league/oauth2-client": "^2.7"
},
"autoload": {
"psr-4": {
Expand Down
11 changes: 6 additions & 5 deletions php/tests/vaas/VaasTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,6 @@
use VaasSdk\Message\Verdict;
use VaasSdk\Sha256;

use function PHPUnit\Framework\assertEquals;

final class VaasTest extends TestCase
{
use ProphecyTrait;
Expand Down Expand Up @@ -382,7 +380,8 @@ private function getUuid(): string
* @throws VaasAuthenticationException
* @throws TimeoutException
*/
public function testForUrl_WithInvalidUrl_ThrowsVaasClientException() {
public function testForUrl_WithInvalidUrl_ThrowsVaasClientException()
{
$vaas = new Vaas($_ENV["VAAS_URL"], $this->_getDebugLogger());
$this->expectException(\InvalidArgumentException::class);
$this->expectExceptionMessage("Url is not valid");
Expand All @@ -397,7 +396,8 @@ public function testForUrl_WithInvalidUrl_ThrowsVaasClientException() {
* @throws VaasAuthenticationException
* @throws TimeoutException
*/
public function testForUrl_WithNull_ThrowsVaasClientException() {
public function testForUrl_WithNull_ThrowsVaasClientException()
{
$vaas = new Vaas($_ENV["VAAS_URL"], $this->_getDebugLogger());
$this->expectException(\TypeError::class);
$vaas->Connect($this->getClientCredentialsGrantAuthenticator()->getToken());
Expand All @@ -411,7 +411,8 @@ public function testForUrl_WithNull_ThrowsVaasClientException() {
* @throws VaasAuthenticationException
* @throws TimeoutException
*/
public function testForUrl_WithStatus4xx_ThrowsVaasClientException() {
public function testForUrl_WithStatus4xx_ThrowsVaasClientException()
{
$vaas = new Vaas($_ENV["VAAS_URL"], $this->_getDebugLogger());
$this->expectException(VaasClientException::class);
$this->expectExceptionMessage("Call failed with status code 404 (Not Found): GET https://upload.production.vaas.gdatasecurity.de/nocontenthere");
Expand Down

0 comments on commit 0f82646

Please sign in to comment.