some adjustments for open handles

GDATASoftwareAG · Nov 8, 2024 · 0f6afbb · 0f6afbb
1 parent 1dff12d
commit 0f6afbb
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 2 deletions.
diff --git a/php/.vscode/settings.json b/php/.vscode/settings.json
@@ -2,5 +2,6 @@
     "phpunit.phpunit": "/workspaces/vaas/php/tests/vaas/vendor/bin/phpunit",
     "phpunit.php": "/usr/local/bin/php",
     "php.debug.ideKey": "vsc",
-    "php.debug.executablePath": "/usr/local/bin/php"
+    "php.debug.executablePath": "/usr/local/bin/php",
+    "php.suggest.basic": false
 }
diff --git a/php/examples/VaasExample/.gitignore b/php/examples/VaasExample/.gitignore
@@ -0,0 +1 @@
+files/*
diff --git a/php/src/vaas/Vaas.php b/php/src/vaas/Vaas.php
@@ -196,14 +196,18 @@ public function ForFile(string $path, $upload = true, string $uuid = null): Vaas
             $fileStream = \Amp\File\openFile($path, 'r');
             $fileSize = \filesize($path);
 
-            return new VaasVerdict(
+            $verdict = new VaasVerdict(
                 $this->UploadStream(
                     $fileStream,
                     $verdictResponse->url,
                     $verdictResponse->upload_token,
                     $fileSize,
                     $verdictResponse->guid)
             );
+
+            $fileStream->close();
+
+            return $verdict;
         }
 
         return new VaasVerdict($verdictResponse);

diff --git a/php/src/vaas/VaasConnection.php b/php/src/vaas/VaasConnection.php
@@ -147,6 +147,10 @@ public function GetResponse($requestId): DeferredFuture {
         return $future;
     }
 
+    public function RemoveResponse($requestId): void {
+        $this->responses->delete($requestId);
+    }
+
     public function GetConnectedWebsocket(): WebsocketConnection
     {
         if (!isset($this->WebSocketClient)) {