Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add logging for backing parameters #94

Merged
merged 2 commits into from
Oct 11, 2023
Merged

Add logging for backing parameters #94

merged 2 commits into from
Oct 11, 2023

Conversation

cakeless
Copy link
Contributor

@cakeless cakeless commented May 3, 2023

No description provided.

@cakeless cakeless force-pushed the Add-logging-for-backing-Parameters branch 6 times, most recently from 134bd8e to ebb1bcf Compare May 5, 2023 13:10
@sonarqubecloud
Copy link

sonarqubecloud bot commented May 5, 2023

[InMemoryScanner Plugin] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarqubecloud
Copy link

sonarqubecloud bot commented May 5, 2023

[ApiTracing Plugin] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 5 Code Smells

54.4% 54.4% Coverage
0.0% 0.0% Duplication

@sonarqubecloud
Copy link

sonarqubecloud bot commented May 5, 2023

[VMICore] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@rageagainsthepc rageagainsthepc force-pushed the main branch 2 times, most recently from 0808756 to 29b1340 Compare May 26, 2023 11:41
@rageagainsthepc
Copy link
Member

I've given this PR a little bit of thought and perhaps there is a relatively easy solution that avoids committing to a json structure in the plugin: std::multimap

@cakeless cakeless force-pushed the Add-logging-for-backing-Parameters branch 2 times, most recently from 6602d9f to dc97977 Compare July 18, 2023 08:22
@sonarqubecloud
Copy link

[InMemoryScanner Plugin] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@cakeless cakeless force-pushed the Add-logging-for-backing-Parameters branch 4 times, most recently from 7e74ae6 to c7f459c Compare July 24, 2023 11:22
@cakeless cakeless force-pushed the Add-logging-for-backing-Parameters branch from c7f459c to 75d0f7f Compare July 24, 2023 11:35
@cakeless cakeless force-pushed the Add-logging-for-backing-Parameters branch from 75d0f7f to 02debb0 Compare July 24, 2023 12:28
@cakeless cakeless force-pushed the Add-logging-for-backing-Parameters branch 11 times, most recently from 1696c01 to f9023fb Compare October 4, 2023 09:54
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 4, 2023

[VMICore] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@cakeless cakeless force-pushed the Add-logging-for-backing-Parameters branch 4 times, most recently from 88b8c2e to 9b7e404 Compare October 4, 2023 11:07
@cakeless cakeless force-pushed the Add-logging-for-backing-Parameters branch 2 times, most recently from bc221ce to c602fb7 Compare October 4, 2023 12:37
rageagainsthepc
rageagainsthepc approved these changes Oct 5, 2023
View reviewed changes
Copy link
Member

@rageagainsthepc rageagainsthepc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM apart from a few nits.

@cakeless cakeless force-pushed the Add-logging-for-backing-Parameters branch 2 times, most recently from 5a198f2 to 88b5731 Compare October 5, 2023 13:29
@cakeless cakeless force-pushed the Add-logging-for-backing-Parameters branch from 88b5731 to 18b4dcf Compare October 6, 2023 10:37
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 6, 2023

[ApiTracing Plugin] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

29.4% 29.4% Coverage
0.0% 0.0% Duplication

@rageagainsthepc
Copy link
Member

@cakeless Are you planning to squash those commits? I am asking because it looks like the nits have been amended to the latest commit.

@cakeless cakeless merged commit 99354b1 into main Oct 11, 2023
5 checks passed
@cakeless cakeless deleted the Add-logging-for-backing-Parameters branch October 11, 2023 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rageagainsthepc rageagainsthepc rageagainsthepc approved these changes

@K-Mayer K-Mayer Awaiting requested review from K-Mayer K-Mayer is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cakeless @rageagainsthepc @K-Mayer