Add inline documentation #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rageagainsthepc
force-pushed
the
inline-documentation
branch
from
ea26dd7 to
f30ce67
Compare
K-Mayer
reviewed
Dec 7, 2023
| /** | ||
| * Only useful if using a gRPC connection, does nothing otherwise. Will send an inmemory scanner detection event | ||
| * via a gRPC channel. | ||
| */ | ||
| virtual void sendInMemDetectionEvent(std::string_view message) const = 0; |
There was a problem hiding this comment.
nit: Not part of this PR, but I think we should replace this with a more plugin agnostic version.
There was a problem hiding this comment.
Sure, you could create an issue for that.
rageagainsthepc
force-pushed
the
inline-documentation
branch
from
f30ce67 to
6e6fa24
Compare
rageagainsthepc
force-pushed
the
inline-documentation
branch
2 times, most recently
from
407caa0 to
879fc49
Compare
rageagainsthepc
force-pushed
the
inline-documentation
branch
from
879fc49 to
08467e8
Compare
|
[VMICore] Kudos, SonarCloud Quality Gate passed!
|
K-Mayer
approved these changes
Dec 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.