Skip to content

Use lossy conversion for string fields #41

Use lossy conversion for string fields

Use lossy conversion for string fields #41

Triggered via pull request March 21, 2024 10:56
Status Failure
Total duration 1m 27s
Artifacts

rust.yml

on: pull_request
Fit to window
Zoom out
Zoom in

Annotations

3 errors and 2 warnings
explicit call to `.into_iter()` in function argument accepting `IntoIterator`: src/grpc_logger.rs#L34
error: explicit call to `.into_iter()` in function argument accepting `IntoIterator` --> src/grpc_logger.rs:34:33 | 34 | self.base_fields.extend(fields.into_iter()); | ^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `fields` | note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` --> /rustc/5680fa18feaa87f3ff04063800aec256c3d4b4be/library/core/src/iter/traits/collect.rs:377:18 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
explicit call to `.into_iter()` in function argument accepting `IntoIterator`: src/console_logger.rs#L47
error: explicit call to `.into_iter()` in function argument accepting `IntoIterator` --> src/console_logger.rs:47:33 | 47 | self.base_fields.extend(fields.into_iter()); | ^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `fields` | note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` --> /rustc/5680fa18feaa87f3ff04063800aec256c3d4b4be/library/core/src/iter/traits/collect.rs:377:18 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion = note: `-D clippy::useless-conversion` implied by `-D warnings`
rust-lint
Clippy had exited with the 101 exit code
rust-lint
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions-rs/clippy-check@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
rust-lint
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/