Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds some sanity checks before the actual scan #169

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

unglaublicherdude
Copy link
Member

The change with the quotes where done by my linter but I would still suggest to apply them because fixed strings should always use ' while " should only be used if you actually want to substitute a variable into the string.

As you can see on the Strings page of the PHP Docs with the double quotes many interpretations are done that can basically be avoided doing by mistake when using single quotes.

@unglaublicherdude
Copy link
Member Author

unglaublicherdude commented Dec 21, 2024

I just realized that this pr is only logging and not avoiding the actual problem. We would have to either return an unknown verdict or so that and tag the ID as won't scan.

But won't scan might not be correct when you read the customer issue. There is a chance that we tag the wrong file (which might be a general issue in our App). And just returning unknown might lead to the same file being scanned over and over again.

I suspect there is still something wrong with our query, so we get out wrong Ids from it or we miss some kind of enabled status in the db. Just speculations thought.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

File 381191 could not be scanned with GData VaaS because there was a temporary upstream server error
3 participants