147 but by adjusting the avirwrapper #157
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The client_host is autodiscovered by the HTTP-Headers like described on the [all_settings page](https://xdebug.org/docs/all_settings) of xdebug. Search for client_discovery_header. You only have to set a client_host for the cli client, but that cannot be done automatically because the container ip is rather dynamic (and depends on the docker-host configuration).
lennartdohmann
requested changes
Nov 7, 2024
| // this will remove the file from the ui and respond to the sync client that the sync failed | ||
| $cache = $this->getCache($path); | ||
| $cache->remove($path); | ||
|
|
||
| $this->unlink($path); |
There was a problem hiding this comment.
Didn't we check during debugging that we do not reach this point at all via the client upload? I can't reproduce that it works like this either. Am I missing something?
There was a problem hiding this comment.
yes. But I did debug again and reached that point. I guess, where was still something itchy on your configuration. Let's check that together today.
|
closed because it does not work. there was some container-stuff cached. we evaluate the possibility to to this with an event-based approach |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.