Don't run the test step for now

GDATASoftwareAG · Jun 11, 2024 · c1389bf · c1389bf
1 parent bbd48f1
commit c1389bf
Show file tree

Hide file tree

Showing 3 changed files with 31 additions and 29 deletions.
diff --git a/.github/workflows/release-app.yml b/.github/workflows/release-app.yml
@@ -8,35 +8,35 @@ on:
     branches: ["main"]
 
 jobs:
-  test:
-    runs-on: ubuntu-latest
-    steps:
-      - uses: actions/checkout@v4
-      - uses: actions/setup-node@v4
-        name: setup node
-        with:
-          node-version: 20
-      - name: Setup BATS
-        uses: mig4/setup-bats@v1
-        with:
-          bats-version: 1.11.0
-      - uses: docker-practice/actions-setup-docker@master
-      - name: install nextcloud
-        env:
-          CLIENT_ID: ${{ secrets.VAAS_CLIENT_ID }}
-          CLIENT_SECRET: ${{ secrets.VAAS_CLIENT_SECRET }}
-        run: ./install.sh
+  # test:
+  #   runs-on: ubuntu-latest
+  #   steps:
+  #     - uses: actions/checkout@v4
+  #     - uses: actions/setup-node@v4
+  #       name: setup node
+  #       with:
+  #         node-version: 20
+  #     - name: Setup BATS
+  #       uses: mig4/setup-bats@v1
+  #       with:
+  #         bats-version: 1.11.0
+  #     - uses: docker-practice/actions-setup-docker@master
+  #     - name: install nextcloud
+  #       env:
+  #         CLIENT_ID: ${{ secrets.VAAS_CLIENT_ID }}
+  #         CLIENT_SECRET: ${{ secrets.VAAS_CLIENT_SECRET }}
+  #       run: ./install.sh
 
-#      - name: run tests
-#        env:
-#          CLIENT_ID: ${{ secrets.VAAS_CLIENT_ID }}
-#          CLIENT_SECRET: ${{ secrets.VAAS_CLIENT_SECRET }}
-#        run: bats --no-parallelize-across-files --jobs 3 ./tests
+  #     - name: run tests
+  #       env:
+  #         CLIENT_ID: ${{ secrets.VAAS_CLIENT_ID }}
+  #         CLIENT_SECRET: ${{ secrets.VAAS_CLIENT_SECRET }}
+  #       run: bats --no-parallelize-across-files --jobs 3 ./tests
 
-      - uses: actions/upload-artifact@master
-        with:
-          name: build-dir
-          path: build/
+  #     - uses: actions/upload-artifact@master
+  #       with:
+  #         name: build-dir
+  #         path: build/
 
   release:
     needs:
@@ -50,6 +50,9 @@ jobs:
           name: build-dir
           path: build/
 
+      - name: Build for appstore
+        run: make appstore
+
       - name: replace version
         id: replace-version
         if: startsWith(github.ref, 'refs/tags/')

diff --git a/Makefile b/Makefile
@@ -107,7 +107,7 @@ distclean: clean
 # Builds the source package for the app store, ignores php tests, js tests
 # and build related folders that are unnecessary for an appstore release
 .PHONY: appstore
-appstore:
+appstore: build
 	rm -rf $(appstore_build_directory)
 	mkdir -p $(appstore_build_directory)
 	tar czf $(appstore_package_name).tar.gz \

diff --git a/install.sh b/install.sh
@@ -17,7 +17,6 @@ do
   sleep 2
 done
 
-make build
 make appstore
 tar -xf ./build/artifacts/gdatavaas.tar.gz -C ./build/artifacts
 docker cp ./build/artifacts/gdatavaas nextcloud-container:/var/www/html/apps/