Possibly expensive SQL Query on determining files to process #144

Cast fileid to objectid and use the index
GDATASoftwareAG · Oct 16, 2024 · 2550edb · 2550edb
1 parent e5eceab
commit 2550edb
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/lib/Db/DbFileMapper.php b/lib/Db/DbFileMapper.php
@@ -26,7 +26,7 @@ public function getFileIdsWithoutTags(array $excludedTagIds, int $limit, int $of
 
 		$qb->select('f.fileid')
 			->from($this->getTableName(), 'f')
-			->leftJoin('f', 'systemtag_object_mapping', 'o', $qb->expr()->eq('f.fileid', $qb->createFunction($this->getPlatformSpecificCast())))
+			->leftJoin('f', 'systemtag_object_mapping', 'o', $qb->expr()->eq('o.objectid', $qb->createFunction('CAST(f.fileid AS VARCHAR(64))')))
 			->leftJoin('f', 'mimetypes', 'm', $qb->expr()->eq('f.mimetype', 'm.id'))
 			->where($qb->expr()->notIn('o.systemtagid', $qb->createNamedParameter($excludedTagIds, IQueryBuilder::PARAM_INT_ARRAY)))
 			->orWhere($qb->expr()->isNull('o.systemtagid'))
@@ -65,7 +65,7 @@ public function getFileIdsWithTags(array $includedTagIds, int $limit, int $offse
 
 		$qb->select('f.fileid')
 			->from($this->getTableName(), 'f')
-			->leftJoin('f', 'systemtag_object_mapping', 'o', $qb->expr()->eq('f.fileid', $qb->createFunction($this->getPlatformSpecificCast())))
+			->leftJoin('f', 'systemtag_object_mapping', 'o', $qb->expr()->eq('o.objectid', $qb->createFunction('CAST(f.fileid AS VARCHAR(64))')))
 			->leftJoin('f', 'mimetypes', 'm', $qb->expr()->eq('f.mimetype', 'm.id'))
 			->where($qb->expr()->in('o.systemtagid', $qb->createNamedParameter($includedTagIds, IQueryBuilder::PARAM_INT_ARRAY)))
 			->andWhere($qb->expr()->notLike('m.mimetype', $qb->createNamedParameter('%unix-directory%')))