Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make tempfolders configurable #47

Merged
merged 4 commits into from
Jun 18, 2024
Merged

Make tempfolders configurable #47

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b0b806f
also debug the autoupdate
unglaublicherdude Jun 18, 2024
5b446cb
add changes to the readme
unglaublicherdude Jun 18, 2024
827a974
increase chart version
unglaublicherdude Jun 18, 2024
f51a158
fix value path
unglaublicherdude Jun 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 14 additions & 10 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,13 +62,17 @@ helm upgrade gdscan gdscan/gdscan -f values.yaml

# Options

| Name | Description | Value |
| ------------------------------- | --------------------------------------------------------------------------------------------------------------------- | ------------------------ |
| `service.type` | service type | `ClusterIP` |
| `service.ports.api` | API service port | `8080` |
| `service.annotations` | service annotations | `{}` |
| `replicaCount` | number of pods | `1` |
| `autoscaling.enabled` | enable auto scaling | `false` |
| `autoscaling.maxReplicas` | maximum number of replicas | `20` |
| `autoscaling.metrics` | custom metrics for auto scaling | |
| `terminationGracePeriodSeconds` | max time in seconds for scans to complete | `30` |
| Name | Description | Value |
| ------------------------------- | -------------------------------------------------------------------------------- | ----------- |
| `service.type` | service type | `ClusterIP` |
| `service.ports.api` | API service port | `8080` |
| `service.annotations` | service annotations | `{}` |
| `replicaCount` | number of pods | `1` |
| `autoscaling.enabled` | enable auto scaling | `false` |
| `autoscaling.maxReplicas` | maximum number of replicas | `20` |
| `autoscaling.metrics` | custom metrics for auto scaling | |
| `terminationGracePeriodSeconds` | max time in seconds for scans to complete | `30` |
| `debug` | when activated the containers produce more verbose eg for analysing scan timings | `false` |
| `server.tempfolder.inmemory` | activates inmemory tempfolder | `false` |
| `client.tempfolder.inmemory` | activates inmemory tempfolder | `false` |

2 changes: 1 addition & 1 deletion charts/gdscan/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,4 +5,4 @@ maintainers:
- name: G DATA CyberDefense AG
email: [email protected]
type: application
version: 1.9.0
version: 1.9.1
20 changes: 20 additions & 0 deletions charts/gdscan/templates/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,11 +36,31 @@ spec:
{{- end }}
{{- end }}
- name: server-tmp
{{- if or (.Values.server.tempfolder.inmemory) (.Values.server.tempfolder.sizeLimit.enabled) }}
emptyDir:
{{- if .Values.server.tempfolder.sizeLimit.enabled }}
sizeLimit: {{ .Values.server.tempfolder.sizeLimit.size | quote }}
{{- end }}
{{- if .Values.server.tempfolder.inmemory }}
medium : "Memory"
{{- end }}
{{- else }}
emptyDir: {}
{{- end }}
- name: scan-socket
emptyDir: {}
- name: client-tmp
{{- if or (.Values.client.tempfolder.inmemory) (.Values.client.tempfolder.sizeLimit.enabled) }}
emptyDir:
{{- if .Values.client.tempfolder.sizeLimit.enabled }}
sizeLimit: {{ .Values.client.tempfolder.sizeLimit.size | quote }}
{{- end }}
{{- if .Values.client.tempfolder.inmemory }}
medium : "Memory"
{{- end }}
{{- else }}
emptyDir: {}
{{- end }}
- name: server-var-log
emptyDir: {}
{{- include "gdscan.imagePullSecrets" . | nindent 6 }}
Expand Down
10 changes: 10 additions & 0 deletions charts/gdscan/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,11 @@ server:
repository: ghcr.io/gdatasoftwareag/vaas/scanserver
pullPolicy: Always
tag: 1
tempfolder:
inmemory: false
sizeLimit:
enabled: false
size: 1Gi
containerSecurityContext:
enabled: true
readOnlyRootFilesystem: true
Expand All @@ -19,6 +24,11 @@ server:
runAsUser: 1001
client:
name: client
tempfolder:
inmemory: false
sizeLimit:
enabled: false
size: 1Gi
image:
repository: ghcr.io/gdatasoftwareag/vaas/scanclient
pullPolicy: Always
Expand Down