Bug - 2725 - Fix Schema Check Action #2738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patcon
reviewed
May 16, 2022
Comment on lines
19
to
20
| with: | ||
| ref: ${{ github.head_ref }} |
There was a problem hiding this comment.
I think we'd want to leave this as it was before? The checkout action is smart about this, and uses GITHUB_REF provided by GitHub, which already varies based on the trigger event: a merge commit for pull_request triggers, and HEAD ref on push triggers.
Did you mean to make this change, or were just copying from the previous actions README?
There was a problem hiding this comment.
Oh, I was just following the README and it worked so I didn't change anything.
patcon
approved these changes
May 16, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2725
Summary
Our
check-lighthouse-schema.ymlworkflow was passing with errors due to a bug with the chosen action. This PR replaces the existing library with a simple custom command which is properly reporting failures as seen in the test PR.Screenshot
Failing on Purpose
Ref: https://github.com/GCTC-NTGC/gc-digital-talent/runs/6427201880?check_suite_focus=true
Success with No Changes