Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] Notification dialog z-index #12059

Merged
merged 1 commit into from
Nov 21, 2024
Merged

[Fix] Notification dialog z-index #12059

merged 1 commit into from
Nov 21, 2024

Conversation

esizer
Copy link
Member

@esizer esizer commented Nov 21, 2024

🤖 Resolves #12020

👋 Introduction

Fixes the action dropdown in the notification dialog to be a higher z-index than the dialog content.

🧪 Testing

  1. Build app pnpm run dev:fresh
  2. Login as any user
  3. Force a notification
  4. Open the notification dialog
  5. Open the actions menu for the notification (vertical ellipses)
  6. Confirm the menu is visible

📸 Screenshot

2024-11-21_11-31

@vd1992 vd1992 self-requested a review November 21, 2024 17:24
vd1992
vd1992 approved these changes Nov 21, 2024
View reviewed changes
Copy link
Contributor

@vd1992 vd1992 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All seems to look good!

@esizer esizer added this pull request to the merge queue Nov 21, 2024
Merged via the queue into main with commit 4a4cc5b Nov 21, 2024
12 checks passed
@esizer esizer deleted the 12020-fix-notification-z-index branch November 21, 2024 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vd1992 vd1992 vd1992 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🐛 Notification action menu is hidden behind notification pane on UAT
2 participants
@esizer @vd1992