Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Copy] Updates nav menu actions to use sentence case #12025

Merged
merged 2 commits into from
Nov 20, 2024
Merged

[Copy] Updates nav menu actions to use sentence case #12025

merged 2 commits into from
Nov 20, 2024

Conversation

mnigh
Copy link
Contributor

@mnigh mnigh commented Nov 20, 2024

🤖 Resolves #12016.

👋 Introduction

This PR updates the open and close nav menu actions to use sentence case instead of title case.

🧪 Testing

  1. pnpm build
  2. Navigate to http://localhost:8000/en/
  3. Verify nav menu button action reads Open menu
  4. Open nav menu
  5. Verify nav menu button action reads Close menu

📸 Screenshots

Screen Shot 2024-11-20 at 09 35 17 Screen Shot 2024-11-20 at 09 35 23

esizer
esizer approved these changes Nov 20, 2024
View reviewed changes
Copy link
Member

@esizer esizer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@mnigh mnigh added this pull request to the merge queue Nov 20, 2024
Merged via the queue into main with commit 7ce76a9 Nov 20, 2024
11 checks passed
@mnigh mnigh deleted the 12016-copy-nav-menu-actions branch November 20, 2024 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@esizer esizer esizer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🔤 Nav menu actions use title case instead of sentence case
2 participants
@mnigh @esizer