Skip to content
This repository has been archived by the owner on Jul 16, 2022. It is now read-only.

Release 4.1.0 | Aesthetic, functionality changes and a rewrite #184

Merged
merged 778 commits into from
Dec 31, 2017

Conversation

vladfrangu
Copy link
Member

@vladfrangu vladfrangu commented Jun 27, 2017

Things to consider

This version changes everything. You will have to update your values from config.json and auth.json to their respective JS counterparts.

You will also notice 1 pre-assigned API key in auth.js, and thats no mistake.

Warning

Do NOT Run this branch. Don't. At the time of writing this (or rewriting), the bot has NO core features available. Its a full rewrite. Wait till I'll edit this and tell you you may go ahead and give it a test run, at your own risk.
And, if you find any bugs, or you'd like a code refactor, drop a comment.

The aim of this Pull Request

This Pull Request is aimed to rewrite and improve the bot. Everything will look better, should work faster, and best of all, everything should and will work.

What does this Pull Request Contain

  • A full bot rewrite, to Discord.js

  • Improvements to the command looks and feel

  • Addition of smaller things

  • A new god damn Extension API

Current Progress

  • Delete the old files

  • Rewrite the main base, using async

  • Port all of the commands

  • Fix broken shit (giveaway, lottery, MOTD constantly repeating etc)

  • Test things

  • Pray to Vlag

Old Credit should go where its due

(This is here for consistency, these credits affect the old Eris commits)

Thanks TTtie ( @TTtie ) for the help provided with the GetUserWithoutREST, helping me test the info command due to me refactoring some code and with the inspiration for the debug command

@vladfrangu vladfrangu added target: Commands Issues that target Command files don't merge - WIP type: Enhancement Issues that enhance an existing feature or module type: Feature Issues that request or implement a new feature or module labels Jun 27, 2017
@vladfrangu
Copy link
Member Author

Mark my words @GilbertGobbels if you don't do a full check on all the code and commands I'll kill you!

@TTtie
Copy link
Contributor

TTtie commented Jun 30, 2017

and i raprot u to dismcord for telling u hurt gilbert

@vladfrangu
Copy link
Member Author

cough image

@TTtie
Copy link
Contributor

TTtie commented Jun 30, 2017

O kurva.....

@vladfrangu
Copy link
Member Author

Hey @GilbertGobbels promise me that you will respect the eslint rules or I'll personally setup travis and tests for eslint which will prevent PR's from merging unless rules are met:tm:

Don't do a javascript await meme i swear

@vladfrangu
Copy link
Member Author

Wasn't eslint, i just did it cause

It works

It makes more sense

@vladfrangu
Copy link
Member Author

Need to rewrite the main message.. fuck

@vladfrangu vladfrangu changed the title Release 4.0.2 | Aesthetic, functionality changes and fixes Release 4.0.2 | Aesthetic, functionality changes and a rewrite Jul 18, 2017
Discord.js Outdated
/* eslint-disable max-len */
module.exports = (db, configJS, configJSON) => {
// Create a Discord.js Bot Client
const Discord = require("discord.js");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rip eris in gab 2016(?) - 2017.

@vladfrangu
Copy link
Member Author

10/10 that was either a sarcastic thanks, or a legit thanks 🤣

@vladfrangu
Copy link
Member Author

When codacity will bang us 😂

@vladfrangu vladfrangu added this to the v4.1.0 milestone Aug 1, 2017
@TTtie
Copy link
Contributor

TTtie commented Aug 1, 2017

DAhaa

@vladfrangu vladfrangu changed the title Release 4.0.2 | Aesthetic, functionality changes and a rewrite Release 4.1.0 | Aesthetic, functionality changes and a rewrite Aug 3, 2017
@vladfrangu
Copy link
Member Author

Version 4.1 it is! 🎉

@TTtie
Copy link
Contributor

TTtie commented Aug 3, 2017

👀

screenshot_20170803-124100

@Gilbert142 Gilbert142 added the target: Extensions Issues that target the Extension handler or API label Aug 6, 2017
Frangu Vlad and others added 25 commits December 28, 2017 22:47
The text really loved sticking to itself. Now it listens like a good boi
Made the ranks command, cleaned up checkRank, fixed a logMessage bug.
Convert your currency or your length...if that's what you're into..
You'll need an Open Exchange Rate Key (which is free, for 1000 queries per month)
We also cache the results in a local JSON, so while the results at boot may be outdated (they will update over time), you won't go nuts on your usage quota!
Calculating conversions. :lul:
Because it doesn't update properly. @KingDGrizzle update the rest please!
@Gilbert142 Gilbert142 merged commit 5a1f591 into development Dec 31, 2017
@vitalkanev
Copy link
Contributor

I guess done @GilbertGobbels?

@vladfrangu
Copy link
Member Author

Please note that this can be counted as PR 1 out of many when it comes to the rewrite. Expect more PRs

@TTtie
Copy link
Contributor

TTtie commented Jan 1, 2018

that reminds me of the thing that I should work on #202

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
priority: Critical Issues that require critical priority to be handled s: In Progress Issues which are WIP and should not be finished/merged. The issue is in progress target: Commands Issues that target Command files target: Extensions Issues that target the Extension handler or API target: Internals Issues that target GAB Internals target: Web Issues that target GAB's Web Server type: Enhancement Issues that enhance an existing feature or module type: Feature Issues that request or implement a new feature or module version: Breaking Issues that introduce changes that are not backwards compatible
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants