add area join support and test (#381) #397
Open
+47
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
larrytamnjong
commented
Nov 19, 2024
There was a problem hiding this comment.
Hi @marcin-krystianc
I'm confused about this. Which address should I provide for the test?
There was a problem hiding this comment.
Did you try to run it locally ? What are the logs in the consul agent?
There was a problem hiding this comment.
It's an EnterpriseOnlyFact so it skips when running locally.
There was a problem hiding this comment.
It is possible to run enterprise tests locally. You can download the old version (e.g. 1.9+ent of enterprise consul which will run locally for an hour). Then you need either set the appropriate env variable or just replace the tests attribute with [Fact].
There was a problem hiding this comment.
@marcin-krystianc here is the response from the consul agent
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.