Added <summary> to GetCARoots, added GetCARoots with QueryOptions parameter #338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@marcin-krystianc the PR with fixes to #332 |
Consul/Agent.cs
Outdated
| /// GetCARoots returns root certificates in the cluster | ||
| /// </summary> | ||
| /// <param name="ct">Cancellation Token</param> | ||
| /// <returns>Root certificates</returns> | ||
| public async Task<QueryResult<CARoots>> GetCARoots(CancellationToken ct = default) | ||
| { | ||
| return await _client.Get<CARoots>("v1/agent/connect/ca/roots", QueryOptions.Default).Execute(ct).ConfigureAwait(false); |
There was a problem hiding this comment.
Can you call the other overload to avoid repeating the implementation.
Suggested change
| return await _client.Get<CARoots>("v1/agent/connect/ca/roots", QueryOptions.Default).Execute(ct).ConfigureAwait(false); | |
| return await GetCARoots(QueryOptions.Default, ct); |
There was a problem hiding this comment.
Oh, makes sense. Shouldn't it be "return await GetCARoots(QueryOptions.Default, ct).ConfigureAwait(false);" though?
There was a problem hiding this comment.
yeah, you are right.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.