Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add support for logjson #224

Merged
merged 16 commits into from
Aug 7, 2023
Merged

feat: add support for logjson #224

merged 16 commits into from
Aug 7, 2023

Conversation

winstxnhdw
Copy link
Contributor

@winstxnhdw winstxnhdw commented Jul 21, 2023 •
edited
Loading

  • Add v1.7 feature, logjson
  • Add tests pertaining to logjson
  • Applied lint suggestions

marcin-krystianc
marcin-krystianc reviewed Jul 26, 2023
View reviewed changes
Copy link
Contributor

@marcin-krystianc marcin-krystianc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be great to have a simple test, that makes sure that logs returned from the server are actually in the expected format (json, non-json).

Consul/Agent.cs Outdated Show resolved Hide resolved
Consul/Agent.cs Show resolved Hide resolved
@winstxnhdw winstxnhdw marked this pull request as ready for review July 28, 2023 09:24
marcin-krystianc
marcin-krystianc reviewed Jul 28, 2023
View reviewed changes
Consul/Agent.cs Show resolved Hide resolved
Consul/Agent.cs Outdated Show resolved Hide resolved
Consul.Test/AgentTest.cs Outdated Show resolved Hide resolved
marcin-krystianc
marcin-krystianc previously approved these changes Aug 1, 2023
View reviewed changes
Copy link
Contributor

@marcin-krystianc marcin-krystianc left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good, but before merging it, we need to fix the CI .#230

PS: There is a remaining check-format error though.

@marcin-krystianc marcin-krystianc merged commit 0877364 into G-Research:master Aug 7, 2023
147 checks passed
@winstxnhdw winstxnhdw deleted the logjson branch August 9, 2023 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcin-krystianc marcin-krystianc marcin-krystianc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@winstxnhdw @marcin-krystianc