Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pinned windows which stick to the position when moving desktops #261

Merged
merged 1 commit into from
Jun 10, 2024

Conversation

andydotxyz
Copy link
Contributor

@andydotxyz andydotxyz commented Jun 2, 2024

Looking for a little feedback on naming and/or menu for this feature.
Adds "All desktops" to the "move to desktop" menu...

Does it "fit" for X11 and Wayland?

Checklist:

  • Tests included.
  • Lint and formatter run with no errors.
  • Tests all pass.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 9340301264

Details

  • 0 of 24 (0.0%) changed or added relevant lines in 2 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.08%) to 28.602%

Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/ui/desk.go 0 1 0.0%
wm/border.go 0 23 0.0%
Files with Coverage Reduction New Missed Lines %
wm/border.go 1 0.0%
Totals Coverage Status
Change from base Build 9340251877: -0.08%
Covered Lines: 1610
Relevant Lines: 5629

💛 - Coveralls

@andydotxyz
Copy link
Contributor Author

Chat on slack seems to be that the naming is good. Let's see if this gets an approval though :)

@andydotxyz andydotxyz merged commit 905b608 into FyshOS:develop Jun 10, 2024
5 checks passed
@andydotxyz
Copy link
Contributor Author

Merged on 7 day no-changes-requested default.

@andydotxyz andydotxyz deleted the feature/pinwindows branch June 10, 2024 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants