-
-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add quake mode terminal module #256
Conversation
Pull Request Test Coverage Report for Build 7970876290Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
} | ||
t.hide() // terminal exited | ||
|
||
t.createTerm() // reset for next usage |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have tmux auto-launch from my .bashrc (with a check to make sure it isn't already running.) The way this is written here will cause my tmux sessions to pile up rather quickly, if I'm understanding it correctly.
Looks like this behavior might not play nicely with pinentry-ncurses for Yubikey users. Is there a way to only spawn the shell JIT, right before the user actually sees it, rather than optimistically spawning it and leaving it open in the background 24/7 if the module is enabled?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
slightly concerned about implications for sessionized tmux / pinentry but love the idea
I made it lazy load the terminal, that should fix the concern I think? |
Looks good now! |
Last feature addition for v0.4 I think :)
quake-term-final.mp4
Checklist: