Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: remove raw string hashes for readability #689

Closed
wants to merge 1 commit into from
Closed

refactor: remove raw string hashes for readability #689

wants to merge 1 commit into from

Conversation

hamirmahal
Copy link
Contributor

No description provided.

hamirmahal
hamirmahal commented Oct 15, 2024
View reviewed changes
Copy link
Contributor Author

@hamirmahal hamirmahal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This shouldn't cause any user-facing changes.

cargo test passes locally with these changes.

@mrDIMAS
Copy link
Member

mrDIMAS commented Oct 17, 2024

This makes shaders code to essentially collapse into one long line which makes it hard to debug compilation errors.

@hamirmahal
Copy link
Contributor Author

Ah, I see. Feel free to close this pull request if you don't think it's helpful.

@mrDIMAS mrDIMAS closed this Oct 17, 2024
@hamirmahal hamirmahal deleted the refactor/remove-raw-string-hashes-for-readability branch October 17, 2024 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hamirmahal @mrDIMAS