BUG: Guard access to tx.sapData in connectBlock

Fuzzbawls · Dec 15, 2020 · f62ac6c · f62ac6c
1 parent 99a4379
commit f62ac6c
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/src/validation.cpp b/src/validation.cpp
@@ -1670,8 +1670,10 @@ bool ConnectBlock(const CBlock& block, CValidationState& state, CBlockIndex* pin
         UpdateCoins(tx, view, i == 0 ? undoDummy : blockundo.vtxundo.back(), pindex->nHeight);
 
         // Sapling update tree
-        for(const OutputDescription &outputDescription : tx.sapData->vShieldedOutput) {
-            sapling_tree.append(outputDescription.cmu);
+        if (tx.IsShieldedTx() && !tx.sapData->vShieldedOutput.empty()) {
+            for(const OutputDescription &outputDescription : tx.sapData->vShieldedOutput) {
+                sapling_tree.append(outputDescription.cmu);
+            }
         }
 
         vPos.emplace_back(tx.GetHash(), pos);