Not rebuilding SearchIndex every paper_search
#512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamesbraza
requested review from
whitead,
sidnarayanan,
mskarlin and
nadolskit
dosubot
bot
added
the
size:M
jamesbraza
force-pushed
the
splitting-index-build-get
branch
from
5e01fa5 to
b3a2174
Compare
jamesbraza
force-pushed
the
splitting-index-build-get
branch
from
b3a2174 to
2c7cb42
Compare
nadolskit
approved these changes
Oct 1, 2024
mskarlin
reviewed
Oct 1, 2024
| settings: Application settings. | ||
| build: Opt-out flag (default is True) to read the contents of the source paper |
There was a problem hiding this comment.
IMO this logic is a bit complicated for users— what do you think about a “from_directory” class method on the SearchIndex class that you can use when you don’t need to build one? Then you can call that instead of adding an extra flag to this function. Logic looks good otherwise though.
There was a problem hiding this comment.
Looks like you were approximately a few seconds too slow on the PR comment haha.
I didn't decompose get_directory_index in this PR because I was trying to be backwards compatible. I will make a downstream PR that does this then
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
get_directory_indexso everypaper_searchdoesn't have to re-index #488This may take a few minutesless #499