Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix homebrew install #20

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

lyleschemmerling
Copy link

exists doesn't exist any more, but exist exists, so switching that so that the installer won't fail.

@lyleschemmerling lyleschemmerling changed the base branch from main to develop December 10, 2024 20:33
Copy link
Member

@robotdan robotdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we delete fusionauth-search.rb Formula?

We deprecated in Oct 2023 - I think we are only publishing the .deb for our own use at the moment.

@lyleschemmerling lyleschemmerling requested review from a team as code owners December 11, 2024 18:50
@lyleschemmerling
Copy link
Author

@robotdan I can drop the fusionauth-search build here, but there are two reasons why we may not want to:

  1. The version of fusionauth-search in homebrew today is broken the same as fusionauth-app, so if I still really wanted to use it for some reason I can't. We could give it one last run to fix that and THEN remove it. Or we can say "too bad".

  2. Aaron's work on refactor: update brew install and add simple tests #16 will break as he is dependent on the search build to start up fusionauth and test everything works. That workflow would need to be reworked to install opensearch in a different way (either installing docker or approximating what fusionauth search was doing anyway).

If we don't want to worry about either of those right now I can drop search and call it a day

@Aaron-Ritter
Copy link

@lyleschemmerling as discussed, the test was not actively using fusionauth-search instance as the search type was database. It only tested the proper installation start and stop of it. There is a opensearch homebrew installation available in case anyone needs search too. But for most e2e tests search is overkill unless very specific functionality is tested provided by search.

The idea behind the test is to run the 2 latest macos github runner in a matrix workflow to check if 1. the homebrew installation is still functional after each release and 2. is working on the github provided macos runner builds.

Side note, on github macos runner none of the docker implementations i tested work because its missing nested virtualization which is why homebrew for these scenarios is relevant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants