Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display authentication type valid values #3415

Merged
merged 9 commits into from
Dec 9, 2024

Conversation

mooreds
Copy link
Contributor

@mooreds mooreds commented Dec 6, 2024

Previously we were only showing the authenticationType valid values on the token claims page, but it is used in other places:

  • login webhooks
  • login validation lambda response

This PR does a few things:

  • reworks the token claims page to use the AvailableSince component for more consistent styling
  • add the authenticationType values to the missing areas mentioned above
  • changes the authenticationType include file to be better named (no more underscores!)
  • modifies the authenticationType include to take a show_since value, because as types and features are added, displaying availableSince doesn't make sense if the authentiationType was added before the feature was.

@mooreds mooreds requested review from a team as code owners December 6, 2024 17:48
@mooreds
Copy link
Contributor Author

mooreds commented Dec 6, 2024

eslint fails because it is trying to operate on a file I removed. still trying to figure out how to get gh cli to exclude such files.

mooreds and others added 3 commits December 6, 2024 14:12
previous solution picked up missing files, which then cause ESLint to barf

cli/cli#4766 had this solution, because there's no way to get the removed files from the nicer 'pr view' command
Copy link
Contributor

@lyleschemmerling lyleschemmerling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed the eslint issues and used javascript since this is a js repo

@mooreds
Copy link
Contributor Author

mooreds commented Dec 9, 2024

I thought this was a markdown repo @lyleschemmerling :)

@mooreds mooreds merged commit 9d94ec1 into main Dec 9, 2024
3 checks passed
@mooreds mooreds deleted the mooreds/share-authentication-type-values-where-used branch December 9, 2024 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants