-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Display authentication type valid values #3415
Merged
mooreds
merged 9 commits into
main
from
mooreds/share-authentication-type-values-where-used
Dec 9, 2024
Merged
Display authentication type valid values #3415
mooreds
merged 9 commits into
main
from
mooreds/share-authentication-type-values-where-used
Dec 9, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eslint fails because it is trying to operate on a file I removed. still trying to figure out how to get gh cli to exclude such files. |
previous solution picked up missing files, which then cause ESLint to barf cli/cli#4766 had this solution, because there's no way to get the removed files from the nicer 'pr view' command
lyleschemmerling
previously approved these changes
Dec 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I fixed the eslint issues and used javascript since this is a js repo
I thought this was a markdown repo @lyleschemmerling :) |
hjaret
reviewed
Dec 9, 2024
hjaret
approved these changes
Dec 9, 2024
lyleschemmerling
approved these changes
Dec 9, 2024
mooreds
deleted the
mooreds/share-authentication-type-values-where-used
branch
December 9, 2024 21:37
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we were only showing the authenticationType valid values on the token claims page, but it is used in other places:
This PR does a few things: