Add Code Highlighting to RemoteContent #3251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lyleschemmerling
requested changes
Sep 5, 2024
| import { marked } from 'marked'; | ||
| * Remote content fetcher. Remote content is assumed to be markdown. | ||
| */ | ||
| import { Markdown } from "astro-remote"; |
There was a problem hiding this comment.
This is not found, did you include this in the package.json?
There was a problem hiding this comment.
my bad @lyleschemmerling I think I installed before I created the new branch.
|
My concern with this is that this will be at least the third way of parsing markdown into HTML that we have in the site code which is making me a little uneasy. In theory we can do this with what we have already, it just means mucking around in tools yet. And now that I am looking at this I realize that the |
…xpatterson/devrl-765-fix-react-sdk-doc-code-samples # Conflicts: # astro/package-lock.json
lyleschemmerling
approved these changes
Dec 11, 2024
lyleschemmerling
deleted the
alexpatterson/devrl-765-fix-react-sdk-doc-code-samples
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to change
After Change
