adjust regex for rss to include single or double quotes #2935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is what happens when you use regex! We may want to do something more dynamic in future, but shipit for now |
lyleschemmerling
approved these changes
Mar 7, 2024
bhalsey
reviewed
Mar 7, 2024
| @@ -6,7 +6,7 @@ export const getReleaseNoteRssItems = async () => { | |||
| const releaseLines = releaseNotes.body.split("\n"); | |||
| const archiveLines = archive.body.split("\n"); | |||
| const lines = [...releaseLines, ...archiveLines]; | |||
| const items = lines.map(line => line.match(/ReleaseNoteHeading version="([^"]*)" releaseDate="([^"]*)"/)) | |||
| const items = lines.map(line => line.match(/ReleaseNoteHeading version=['"]([^('|")]*)['"] releaseDate=['"]([^('|")]*)['"]/)) | |||
There was a problem hiding this comment.
Suggested change
| const items = lines.map(line => line.match(/ReleaseNoteHeading version=['"]([^('|")]*)['"] releaseDate=['"]([^('|")]*)['"]/)) | |
| const items = lines.map(line => line.match(/ReleaseNoteHeading version=['"]([^'"]*)['"] releaseDate=['"]([^'"]*)['"]/)) |
I think this is what you really want. Otherwise, you're saying not to match any of the chars ('|")
alex-fusionauth
deleted the
2934-rss-for-docsreleasesxml-missing-when-not-using-double-quotes-in-heading
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjusted regex to pick up single or double quotes in the ReleaseNoteHeading
https://inversoft.slack.com/archives/C02H35R1Q6N/p1709842867204509