-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Android Quickstart #2415
Conversation
…ponents to avoid having to type them everytime
How about "Android Java Quickstart"?
How about fusionauth-quickstart-java-android-native (or -mobile)? Either seem accurate.
Hmmm. Can you have this be a config setting, where you stand up FusionAuth with ngrok, update a settings file someplace, then build the android app? |
Done
Done
What do you mean by "config setting"? |
When I am building an android app, is there a corresponding config file, similar to So I'm talking about build time configuration, not runtime configuration. Does that make sense? |
@Aaron-Ritter @ColinFrick please determine who is the best person to review, tagged you both. |
Yes, it does. That's why I asked if it would be better to write these steps to the quickstart (expose the instance with ngrok, update the Issuer, recreate asymmetric keys, update settings file) or create a simple script to do all that. |
Ah, okay. Since this won't be done typically (people will probably work through the quickstart once, not multiple times) I think documentation is fine. |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vcampitelli is this ready for @ColinFrick to re-review? |
Yup, just pushed the kickstart file that was missing. Can you please review it again @ColinFrick ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vcampitelli Quick start looks good. I have found a typo in the kickstart.json.
See FusionAuth/fusionauth-quickstart-java-android-native@8a38be2#r127101206
Done! Thanks @ColinFrick @mooreds this is now ready for you to review |
There are some things that I wanted to check before we can actually merge this:
fusionauth-quickstart-android-java
but the Quickstart instructions expectsfusionauth-quickstart-LANGUAGE-FRAMEWORK-{api,web}
, so maybe I should append-native
? I didn't because it seems redundant.