Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom transform for shades tokens to strip shades prefix #51

Merged
merged 4 commits into from
Aug 5, 2022

Conversation

alexandra-lim
Copy link
Collaborator

This MR:

  • adds a transform for the shades tokens to remove the shades prefix
  • renames the other custom transforms to be a bit more explicit
  • reorders transforms in alphabetical order under the custom transform groups (Aviary and Native) in the build.js file

@alexandra-lim alexandra-lim requested review from CCAyl and iryanclarke and removed request for CCAyl August 4, 2022 22:03
@@ -1,55 +1,75 @@
const StyleDictionary = require("style-dictionary").extend("config.json");
const ChangeCase = require('change-case')
const ChangeCase = require("change-case");
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prettier formatting here updating the quotes style

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran into the same thing when I had my MR yesterday 🤪

@CCAyl
Copy link
Contributor

CCAyl commented Aug 5, 2022

this is a work of art. thanks for cleaning up and renaming the transforms to things that actually make sense <3333

Copy link
Collaborator

@iryanclarke iryanclarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

catbop

@alexandra-lim alexandra-lim merged commit 9103684 into main Aug 5, 2022
@iryanclarke iryanclarke deleted the transform-shade-tokens branch January 23, 2023 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants