Re-do of global namespace removal, and transform action update to support multi files #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iryanclarke
changed the title
|
i think this is g2g! good call on calling in |
CCAyl
approved these changes
Aug 4, 2022
| export const grey800 : string; | ||
| export const shadeswhite : string; | ||
| export const shadesblack : string; |
There was a problem hiding this comment.
i'll do a follow up transformer to get rid of the shades prefix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update allows us to support multi-file sync, as the data structure within the base token file has been changed!
The old structure wrapped each "Section" in a master object, while multi-file sync now exports these into separate files! This meant we had to remove the
globalwrapper in the maintokens.jsonfile, as the references in the Figma Tokens plugin were broken.This, in turn broke our configuration of
transform-tokens, and thus we had to update the npm commands to properly parse these values into raw ones again!