Style dictionary build workflow 3 #30
Conversation
…m/Fullscript/aviary-tokens into style-dictionary-build-workflow-3
…m/Fullscript/aviary-tokens into style-dictionary-build-workflow-3
…m/Fullscript/aviary-tokens into style-dictionary-build-workflow-3
…to style-dictionary-build-workflow-3
…m/Fullscript/aviary-tokens into style-dictionary-build-workflow-3
| commit_message: Transformed tokens | ||
|
|
||
| build_style_dictionary: | ||
| needs: transform_tokens |
There was a problem hiding this comment.
This job won't run unless the transform_tokens job is successful
| @@ -26,12 +21,32 @@ jobs: | |||
| node-version: "14" | |||
| - name: Install Node Dependencies | |||
| run: npm install | |||
| - name: Run token-transformer | |||
| - name: Pull any branch changes | |||
There was a problem hiding this comment.
Doing this in both jobs since we've run into issues where the job errors out in the commit step since it's behind the origin branch
There was a problem hiding this comment.
Interesting, so this basically re-bases the branch with origin, as there was merging errors?
There was a problem hiding this comment.
Yeah, I ran into that issue in this run: https://github.com/Fullscript/aviary-tokens/runs/7115843713?check_suite_focus=true
So I figured just in case it happens again we could have this as a failsafe
| runs-on: ubuntu-latest | ||
|
|
||
| steps: | ||
| - uses: actions/checkout@v3 |
There was a problem hiding this comment.
Gotta do this repetitive work since each job uses a new runner
Apparently third time's the charm!
This MR combines the two existing workflows into one, and sets up each action as individual jobs instead. We're doing this because you can watch one workflow go through its jobs as opposed to switching between two workflows to check (you'll see this in the UI of the successful run below). Cath and I decided that it was worth running this workflow regardless of whether or not the change was made only to the
tokens.jsonfile, or any of the two config files (config.jsonandbuild.js).Check out a successful run here