Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Working module exports and types #26

Merged
merged 4 commits into from
Jun 28, 2022
Merged

Working module exports and types #26

merged 4 commits into from
Jun 28, 2022

Conversation

iryanclarke
Copy link
Collaborator

@iryanclarke iryanclarke commented Jun 28, 2022 •
edited
Loading

Adds in proper exporting of our typography types under the module interface 💯 Also adds in the typing file so we can have proper linting when trying to destructure objects from the package

@iryanclarke iryanclarke changed the title Okay module exports Working module exports and types Jun 28, 2022
alexandra-lim
alexandra-lim approved these changes Jun 28, 2022
View reviewed changes
Copy link
Collaborator

@alexandra-lim alexandra-lim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!!

@iryanclarke iryanclarke merged commit 80fd9d1 into main Jun 28, 2022
@iryanclarke iryanclarke deleted the okay-module-exports branch July 4, 2022 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CCAyl CCAyl CCAyl approved these changes

@alexandra-lim alexandra-lim alexandra-lim approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@iryanclarke @alexandra-lim @CCAyl