Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make light and dark typography tokens match #154

Merged
merged 4 commits into from
Feb 5, 2024
Merged

Conversation

bambie1
Copy link
Contributor

@bambie1 bambie1 commented Feb 5, 2024

we missed h5 and mobileh5 in the dark typography tokens and it was causing typescript issues. So, I've copied over the light typography tokens to dark

"fontSize": "{typography.size.desktop.2xlarge}",
"fontSize": "{typography.size.desktop.3xlarge}",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

main changes were made in this file

@bambie1 bambie1 requested review from iryanclarke and CCAyl February 5, 2024 19:23
Copy link
Contributor

@CCAyl CCAyl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! makes sense.

@bambie1 bambie1 merged commit 3960d3b into main Feb 5, 2024
Copy link
Collaborator

@iryanclarke iryanclarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Damn, didn't even catch that the font size for H1 was wrong in dark, good catch!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants