This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luizstacio
suggested changes
Jun 28, 2022
.github/workflows/pr.yaml
Outdated
NODE_ENV: "test" | ||
# debugging seems to make tests slower randomly. you can include if you need to track issues in CI |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can remove it if will not be required
luizstacio
approved these changes
Jun 28, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the tests are the steps taking more time, now they run in parallel.
This PR also creates some internal ✅
composite
actions to use in our CI workflowyml
files, making them cleaner and shorter.New actions created:
setup-node
,setup-rust
,setup-docker
To use them in a
yml
:This helps avoiding a lot of duplicated code. To fix it I also tried to use:
❌ Reusable workflows - https://docs.github.com/en/actions/using-workflows/reusing-workflows - we're not able to use the same context after executing a reusable workflow, so we cannot use it to build envs. Which is our use case.
❌ Centralize env setup in a docker image - we run a docker environment (
pnpm ci:test
) to run the app, which would lead us to aDocker in Docker
situation. Which is known to have several issues (https://jpetazzo.github.io/2015/09/03/do-not-use-docker-in-docker-for-ci/). Better to make it simples and avoid issues.Closes #309