Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes unreachable on invalid cfg attribute arg. #6553

Merged
merged 1 commit into from
Sep 17, 2024

Conversation

esdrubal
Copy link
Contributor

@esdrubal esdrubal commented Sep 16, 2024

Description

We now throw an error that enforces cfg arg to be a valid one.

Fixes #6326

Checklist

  • I have linked to any relevant issues.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

We now throw an error that enforces cfg arg to be a valid one.

Fixes #6326
@esdrubal esdrubal added bug Something isn't working audit-report Related to the audit report labels Sep 16, 2024
@esdrubal esdrubal self-assigned this Sep 16, 2024
Copy link

codspeed-hq bot commented Sep 16, 2024

CodSpeed Performance Report

Merging #6553 will degrade performances by 18.2%

Comparing esdrubal/unreachable_cfg (851b722) with master (ea4b9e9)

Summary

❌ 1 regressions
✅ 21 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark master esdrubal/unreachable_cfg Change
document_symbol 4.3 ms 5.3 ms -18.2%

@esdrubal esdrubal marked this pull request as ready for review September 17, 2024 10:47
@esdrubal esdrubal requested a review from a team as a code owner September 17, 2024 10:47
@tritao
Copy link
Contributor

tritao commented Sep 17, 2024

CodSpeed Performance Report

Merging #6553 will degrade performances by 18.2%

Comparing esdrubal/unreachable_cfg (851b722) with master (ea4b9e9)

Summary

❌ 1 regressions ✅ 21 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark master esdrubal/unreachable_cfg Change
document_symbol 4.3 ms 5.3 ms -18.2%

I'm getting this same slowdown on one of my PRs.

@JoshuaBatty JoshuaBatty merged commit db74865 into master Sep 17, 2024
41 checks passed
@JoshuaBatty JoshuaBatty deleted the esdrubal/unreachable_cfg branch September 17, 2024 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
audit-report Related to the audit report bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unreachable panic in sway compiler when parsing malicious cfg in contract
3 participants